diff options
| author | Thomas Monjalon <[email protected]> | 2018-04-05 17:33:22 +0200 |
|---|---|---|
| committer | Thomas Monjalon <[email protected]> | 2018-04-18 00:48:41 +0200 |
| commit | d9a42a69febf453cdb735e77fc0e01463ddf4acc (patch) | |
| tree | 02965fc7b153216e78ba1135d440d2085e46c1c0 /examples/server_node_efd | |
| parent | a9dbe180222680edf8c49e86791f972549ce5be3 (diff) | |
ethdev: deprecate port count function
Some DPDK applications wrongly assume these requirements:
- no hotplug, i.e. ports are never detached
- all allocated ports are available to the application
Such application iterates over ports by its own mean.
The most common pattern is to request the port count and
assume ports with index in the range [0..count[ can be used.
In order to fix this common mistake in all external applications,
the function rte_eth_dev_count is deprecated, while introducing
the new functions rte_eth_dev_count_avail and rte_eth_dev_count_total.
Signed-off-by: Thomas Monjalon <[email protected]>
Diffstat (limited to 'examples/server_node_efd')
| -rw-r--r-- | examples/server_node_efd/node/Makefile | 1 | ||||
| -rw-r--r-- | examples/server_node_efd/node/node.c | 2 | ||||
| -rw-r--r-- | examples/server_node_efd/server/Makefile | 1 | ||||
| -rw-r--r-- | examples/server_node_efd/server/init.c | 2 |
4 files changed, 4 insertions, 2 deletions
diff --git a/examples/server_node_efd/node/Makefile b/examples/server_node_efd/node/Makefile index fffbe35767..dc3191a5b3 100644 --- a/examples/server_node_efd/node/Makefile +++ b/examples/server_node_efd/node/Makefile @@ -14,6 +14,7 @@ APP = node # all source are stored in SRCS-y SRCS-y := node.c +CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -O3 CFLAGS += -I$(SRCDIR)/../shared diff --git a/examples/server_node_efd/node/node.c b/examples/server_node_efd/node/node.c index 84f7bcffe9..3b97fbd45d 100644 --- a/examples/server_node_efd/node/node.c +++ b/examples/server_node_efd/node/node.c @@ -320,7 +320,7 @@ main(int argc, char *argv[]) if (parse_app_args(argc, argv) < 0) rte_exit(EXIT_FAILURE, "Invalid command-line arguments\n"); - if (rte_eth_dev_count() == 0) + if (rte_eth_dev_count_avail() == 0) rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n"); rx_ring = rte_ring_lookup(get_rx_queue_name(node_id)); diff --git a/examples/server_node_efd/server/Makefile b/examples/server_node_efd/server/Makefile index cbb91ebe89..d5456f920f 100644 --- a/examples/server_node_efd/server/Makefile +++ b/examples/server_node_efd/server/Makefile @@ -23,6 +23,7 @@ SRCS-y := main.c init.c args.c INC := $(sort $(wildcard *.h)) +CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += $(WERROR_FLAGS) -O3 CFLAGS += -I$(SRCDIR)/../shared diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c index 07b6882f80..7dfe2fa232 100644 --- a/examples/server_node_efd/server/init.c +++ b/examples/server_node_efd/server/init.c @@ -310,7 +310,7 @@ init(int argc, char *argv[]) argv += retval; /* get total number of ports */ - total_ports = rte_eth_dev_count(); + total_ports = rte_eth_dev_count_avail(); /* set up array for port data */ mz = rte_memzone_reserve(MZ_SHARED_INFO, sizeof(*info), |