diff options
| author | David Marchand <[email protected]> | 2023-12-21 14:22:23 +0100 |
|---|---|---|
| committer | David Marchand <[email protected]> | 2024-01-19 12:05:54 +0100 |
| commit | 775ff373216c56acfeffe862c20af2f216c049ea (patch) | |
| tree | 18c40ef3894895ac46416c2ae7ce8d52c33caacd /devtools | |
| parent | f334b4c0b856e92d678cd09828207a3292e24ac2 (diff) | |
devtools: forbid writing to standard output streams
No output on stdout or stderr!
Drivers and libraries must use the logging framework.
Signed-off-by: David Marchand <[email protected]>
Acked-by: Bruce Richardson <[email protected]>
Acked-by: Tyler Retzlaff <[email protected]>
Diffstat (limited to 'devtools')
| -rwxr-xr-x | devtools/checkpatches.sh | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 10d1bf490b..c9e466f736 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -61,6 +61,14 @@ check_forbidden_additions() { # <patch> -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # no output on stdout or stderr + awk -v FOLDERS="lib drivers" \ + -v EXPRESSIONS="\\\<printf\\\> \\\<fprintf\\\(stdout, \\\<fprintf\\\(stderr," \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Writing to stdout or stderr' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # refrain from new additions of rte_panic() and rte_exit() # multiple folders and expressions are separated by spaces awk -v FOLDERS="lib drivers" \ |