summaryrefslogtreecommitdiff
path: root/buildtools
diff options
context:
space:
mode:
authorBruce Richardson <[email protected]>2022-01-20 18:06:39 +0000
committerThomas Monjalon <[email protected]>2022-02-02 15:44:12 +0100
commitecb904cc4596b33aa182e2a7c9edc3104ff981c3 (patch)
treeab7c1e35176bdd2e0809a25dc6402656ec35408c /buildtools
parent44f44d8298d55afa6ea37fc01c7ebd77d8e6f2e2 (diff)
build: fix warnings when running external commands
Meson 0.61.1 is giving warnings that the calls to run_command do not always explicitly specify if the result is to be checked or not, i.e. there is a missing "check" parameter. This is because the default behaviour without the parameter is due to change in the future. We can fix these warnings by explicitly adding into each call whether the result should be checked by meson or not. This patch therefore adds in "check: false" to each run_command call where the result is being checked by the DPDK meson.build code afterwards, and adds in "check: true" to any calls where the result is currently unchecked. Bugzilla ID: 921 Cc: [email protected] Reported-by: Jerin Jacob <[email protected]> Signed-off-by: Bruce Richardson <[email protected]> Tested-by: Jerin Jacob <[email protected]>
Diffstat (limited to 'buildtools')
-rw-r--r--buildtools/meson.build2
1 files changed, 1 insertions, 1 deletions
diff --git a/buildtools/meson.build b/buildtools/meson.build
index 22ea0ba375..400b88f251 100644
--- a/buildtools/meson.build
+++ b/buildtools/meson.build
@@ -45,7 +45,7 @@ if host_machine.system() != 'windows'
endif
foreach module : python3_required_modules
script = 'import importlib.util; import sys; exit(importlib.util.find_spec("@0@") is None)'
- if run_command(py3, '-c', script.format(module)).returncode() != 0
+ if run_command(py3, '-c', script.format(module), check: false).returncode() != 0
error('missing python module: @0@'.format(module))
endif
endforeach