cell adding opers with err check

1 files changed, 40 insertions, 1 deletions

diff --git a/test/test_metric_histogram.cpp b/test/test_metric_histogram.cpp
index 996b1ba..5e3590f 100644
--- a/test/test_metric_histogram.cpp
+++ b/test/test_metric_histogram.cpp
@@ -120,7 +120,46 @@ TEST(metric_test_histogram, serialization_and_merge_twice_with_reset)
     fieldstat_free(instance_total);
 }
 
-// todo: add on wrong cube/metric/cell
+TEST(metric_test_histogram, add_or_set_with_wrong_cell_id_expecting_fail)
+{
+    struct fieldstat *instance = fieldstat_new();
+    int cube_id = fieldstat_register_cube(instance, &TEST_TAG_INT_collided, 1, SAMPLING_MODE_COMPREHENSIVE, 10);
+    int metric_id = fieldstat_register_histogram(instance, cube_id, "czz_test", 1, 600000, 3);
+
+    int ret = fieldstat_histogram_record(instance, cube_id, metric_id, 1, 1234);
+    EXPECT_EQ(ret, -3);
+    ret = fieldstat_histogram_record(instance, cube_id, metric_id, -1, 1234);
+    EXPECT_EQ(ret, -3);
+
+    fieldstat_free(instance);
+}
+
+TEST(metric_test_histogram, add_with_wrong_cube_id_expecting_fail)
+{
+    struct fieldstat *instance = fieldstat_new();
+    int cube_id = fieldstat_register_cube(instance, &TEST_TAG_INT_collided, 1, SAMPLING_MODE_COMPREHENSIVE, 10);
+
+    int ret = fieldstat_histogram_record(instance, cube_id + 1, 0, 1, 1);
+    EXPECT_EQ(ret, -1);
+    ret = fieldstat_histogram_record(instance, -1, 0, 1, 1);
+    EXPECT_EQ(ret, -1);
+
+    fieldstat_free(instance);
+}
+
+TEST(metric_test_histogram, add_with_wrong_metric_id_expecting_fail)
+{
+    struct fieldstat *instance = fieldstat_new();
+    int cube_id = fieldstat_register_cube(instance, &TEST_TAG_INT_collided, 1, SAMPLING_MODE_COMPREHENSIVE, 10);
+    int metric_id = fieldstat_register_histogram(instance, cube_id, "czz_test", 1, 600000, 3);
+
+    int ret = fieldstat_histogram_record(instance, cube_id, metric_id + 1, 1, 1);
+    EXPECT_EQ(ret, -2);
+    ret = fieldstat_histogram_record(instance, cube_id, -1, 1, 1);
+    EXPECT_EQ(ret, -2);
+
+    fieldstat_free(instance);
+}
 
 // todo：测base 64序列化