clear e.printStackTrace() code block.

9 files changed, 6 insertions, 18 deletions

diff --git a/galaxy-common/src/main/java/com/mesalab/common/util/SqlHelper.java b/galaxy-common/src/main/java/com/mesalab/common/util/SqlHelper.java
index 7a25535..e7eec9c 100644
--- a/galaxy-common/src/main/java/com/mesalab/common/util/SqlHelper.java
+++ b/galaxy-common/src/main/java/com/mesalab/common/util/SqlHelper.java
@@ -65,7 +65,6 @@ public class SqlHelper {
             select.setLimit(limit);
             sql = String.valueOf(selectStatement.getSelectBody());
         } catch (Exception e) {
-            e.printStackTrace();
             log.error("Set limit error, SQL is:{} , Error Message is :{} ", sql, e);
         }
 
diff --git a/galaxy-data-engine/src/main/java/com/mesalab/engine/component/calcite/CalciteMemory.java b/galaxy-data-engine/src/main/java/com/mesalab/engine/component/calcite/CalciteMemory.java
index 6ef1dce..88e7f66 100644
--- a/galaxy-data-engine/src/main/java/com/mesalab/engine/component/calcite/CalciteMemory.java
+++ b/galaxy-data-engine/src/main/java/com/mesalab/engine/component/calcite/CalciteMemory.java
@@ -73,7 +73,6 @@ public class CalciteMemory {
             result.put("data", data);
 
         } catch (Exception e) {
-            e.printStackTrace();
             throw new BusinessException("Engine execution SQL Error.", e);
 
         } finally {
diff --git a/galaxy-data-engine/src/main/java/com/mesalab/engine/component/dialect/ClickHouseDialect.java b/galaxy-data-engine/src/main/java/com/mesalab/engine/component/dialect/ClickHouseDialect.java
index 468f347..8cf17d6 100644
--- a/galaxy-data-engine/src/main/java/com/mesalab/engine/component/dialect/ClickHouseDialect.java
+++ b/galaxy-data-engine/src/main/java/com/mesalab/engine/component/dialect/ClickHouseDialect.java
@@ -2,8 +2,6 @@ package com.mesalab.engine.component.dialect;
 
 
 import com.google.common.collect.Maps;
-import com.mesalab.engine.component.bean.SqlQueryBean;
-import com.mesalab.engine.component.bean.ApiQueryBean;
 import com.mesalab.common.dto.results.BaseResult;
 import com.mesalab.common.enums.*;
 import com.mesalab.common.exception.BusinessException;
@@ -12,6 +10,8 @@ import com.mesalab.common.util.SqlHelper;
 import com.mesalab.engine.component.ReportCache;
 import com.mesalab.engine.component.SpringContext;
 import com.mesalab.engine.component.SqlFunction;
+import com.mesalab.engine.component.bean.ApiQueryBean;
+import com.mesalab.engine.component.bean.SqlQueryBean;
 import com.mesalab.engine.component.config.ClickHouseConfig;
 import com.mesalab.engine.component.config.EngineConfig;
 import com.mesalab.engine.service.HttpClientService;
@@ -843,7 +843,6 @@ public class ClickHouseDialect extends AbstractDataSourceDialect {
         try {
             return CCJSqlParserUtil.parseExpression(originalField);
         } catch (JSQLParserException e) {
-            e.printStackTrace();
             throw new BusinessException("parseExpression error: " + originalField);
         }
     }
@@ -933,15 +932,13 @@ public class ClickHouseDialect extends AbstractDataSourceDialect {
         } catch (Exception e) {
             log.error("syntax-check sql error {}, execute original sql: {}, error is: {} ",
                     sql, sql = param.getDbQuerySource().getSqlBody(), e.getMessage() == null ? e.getCause() : e.getMessage());
-            e.printStackTrace();
         }
         return sql;
     }
 
     /**
-     *
      * 做数据集限制: 将最内层sql的表名, 替换成(select * from tableName limit XXX) as alias
-     *   涉及from 和 where中存在子查询
+     * 涉及from 和 where中存在子查询
      *
      * @param sql
      * @return
diff --git a/galaxy-data-engine/src/main/java/com/mesalab/engine/component/dialect/DruidDialect.java b/galaxy-data-engine/src/main/java/com/mesalab/engine/component/dialect/DruidDialect.java
index fce510b..cad27fa 100644
--- a/galaxy-data-engine/src/main/java/com/mesalab/engine/component/dialect/DruidDialect.java
+++ b/galaxy-data-engine/src/main/java/com/mesalab/engine/component/dialect/DruidDialect.java
@@ -180,7 +180,6 @@ public class DruidDialect extends AbstractDataSourceDialect {
         } catch (Exception e) {
             log.error("syntax-check sql error {}, execute original sql: {}, error is: {} ",
                     sql, sql = param.getDbQuerySource().getSqlBody(), e.getMessage() == null ? e.getCause() : e.getMessage());
-            e.printStackTrace();
         }
         return sql;
     }
diff --git a/galaxy-data-engine/src/main/java/com/mesalab/engine/component/udf/TIME_FLOOR_WITH_FILL.java b/galaxy-data-engine/src/main/java/com/mesalab/engine/component/udf/TIME_FLOOR_WITH_FILL.java
index 3d917d3..7e2a839 100644
--- a/galaxy-data-engine/src/main/java/com/mesalab/engine/component/udf/TIME_FLOOR_WITH_FILL.java
+++ b/galaxy-data-engine/src/main/java/com/mesalab/engine/component/udf/TIME_FLOOR_WITH_FILL.java
@@ -147,7 +147,6 @@ public class TIME_FLOOR_WITH_FILL implements UDF {
             targetResult = ConvertUtil.convertTimeseriesToList(targetTimeseriesMap, groupLabel, timeGranLabel);
 
         } catch (Exception e) {
-            e.printStackTrace();
             log.error("Parser function : TIME_FLOOR_WITH_FILL error : " + e);
         }
 
diff --git a/galaxy-data-engine/src/main/java/com/mesalab/engine/service/TestCaseService.java b/galaxy-data-engine/src/main/java/com/mesalab/engine/service/TestCaseService.java
index 07023f8..81a5cba 100644
--- a/galaxy-data-engine/src/main/java/com/mesalab/engine/service/TestCaseService.java
+++ b/galaxy-data-engine/src/main/java/com/mesalab/engine/service/TestCaseService.java
@@ -74,7 +74,6 @@ public class TestCaseService {
                 sql = sql.replaceAll("\\$end_time", "'" + format2.format(date) + "'");
                 sql = URLEncoder.encode(sql, "utf-8").replaceAll("\\+", "%20");
             } catch (Exception e) {
-                e.printStackTrace();
                 log.error("测试用例sql编码错误", e);
             }
             resultTemp = httpClientService.httpGet("http://127.0.0.1:9999/?query=" + sql);
@@ -85,7 +84,6 @@ public class TestCaseService {
                 try {
                     resultTemp.put("query", URLDecoder.decode(sql, "UTF-8"));
                 } catch (Exception e) {
-                    e.printStackTrace();
                     log.error("sql查询结果处理异常", e);
                 }
             }
diff --git a/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/MetadataServiceImpl.java b/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/MetadataServiceImpl.java
index f2c9087..36517dd 100644
--- a/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/MetadataServiceImpl.java
+++ b/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/MetadataServiceImpl.java
@@ -125,7 +125,6 @@ public class MetadataServiceImpl implements MetadataService {
                 Schema schema = new Schema.Parser().parse(item);
                 result.put(schema.getName(), schema);
             } catch (Exception e) {
-                e.printStackTrace();
                 log.error("File: {}, Schema Parser Error: {}", item.getPath(), e);
             }
         }
diff --git a/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/NetworkServiceImpl.java b/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/NetworkServiceImpl.java
index d1d921d..299dd9f 100644
--- a/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/NetworkServiceImpl.java
+++ b/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/NetworkServiceImpl.java
@@ -52,7 +52,6 @@ public class NetworkServiceImpl implements NetworkService {
         try {
             hostAddress = InetAddress.getLocalHost().getHostAddress();
         } catch (UnknownHostException e) {
-            e.printStackTrace();
             log.error("get LocalHost error: ", e);
         }
     }
@@ -256,7 +255,6 @@ public class NetworkServiceImpl implements NetworkService {
         try {
             sql = URLEncoder.encode(sql, "utf-8").replaceAll("\\+", "%20");
         } catch (UnsupportedEncodingException e) {
-            e.printStackTrace();
             hostAddress = "127.0.0.1";
             log.error("sql Encode error: ", e);
         }
diff --git a/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/SystemServiceImpl.java b/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/SystemServiceImpl.java
index f1accfe..7c11d58 100644
--- a/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/SystemServiceImpl.java
+++ b/galaxy-data-engine/src/main/java/com/mesalab/engine/service/impl/SystemServiceImpl.java
@@ -455,9 +455,9 @@ public class SystemServiceImpl implements SystemService {
         try {
             bean = clazz.newInstance();
         } catch (InstantiationException e) {
-            e.printStackTrace();
+            log.error("mapToBean Error:{}",e.getMessage());
         } catch (IllegalAccessException e) {
-            e.printStackTrace();
+            log.error("mapToBean Error:{}",e.getMessage());
         }
         BeanMap beanMap = BeanMap.create(bean);
         beanMap.putAll(map);
@@ -474,7 +474,7 @@ public class SystemServiceImpl implements SystemService {
             try {
                 value = field.get(obj);
             } catch (IllegalAccessException e) {
-                e.printStackTrace();
+                log.error(e.getMessage());
             }
             if (value == null) {
                 value = "";