🧪 test(plugin manager test): fix intrinsic test case

1 files changed, 9 insertions, 5 deletions

diff --git a/infra/plugin_manager/test/plugin_manager_gtest_main.cpp b/infra/plugin_manager/test/plugin_manager_gtest_main.cpp
index 5c35743..e2c88c6 100644
--- a/infra/plugin_manager/test/plugin_manager_gtest_main.cpp
+++ b/infra/plugin_manager/test/plugin_manager_gtest_main.cpp
@@ -1005,7 +1005,7 @@ static void test_basic_session_ctx_free(struct session *sess, void *session_ctx,
 	struct session_plugin_env *env = (struct session_plugin_env *)plugin_env;
 	env->basic_ctx_free_called+=1;
 	struct test_basic_ctx *ctx=(struct test_basic_ctx *)session_ctx;
-	EXPECT_EQ(ctx->called, env->N_per_session_pkt_cnt*2);//ingress + egress + closing
+	EXPECT_EQ(ctx->called, env->N_per_session_pkt_cnt*2);//ingress + egress
 	FREE(ctx);
 	return;
 }
@@ -1037,10 +1037,12 @@ static void test_basic_on_session_egress(struct session *sess, int topic_id, con
 	EXPECT_EQ(sess->plug_mgr_rt->plug_mgr, env->plug_mgr);
 	EXPECT_EQ(session_exdata_set(sess, 2, sess), -1);// illegal set
 	EXPECT_EQ(session_exdata_get(sess, 2), nullptr);// illegal get
-	EXPECT_TRUE(msg!=NULL);
+	if(msg)
+	{
+		env->basic_on_session_egress_called+=1;
+		ctx->called+=1;
+	}
 	EXPECT_EQ(session_exdata_get(sess, env->basic_exdata_idx), sess);
-	env->basic_on_session_egress_called+=1;
-	ctx->called+=1;
 	return;
 }
 
@@ -1076,6 +1078,7 @@ TEST(plugin_manager, session_plugin_on_intrinsic_ingress_egress) {
 	env.intrinsc_egress_topic_id=stellar_mq_get_topic_id(&st, TOPIC_TCP_OUTPUT);
 	EXPECT_GE(env.intrinsc_egress_topic_id, 0);
 	EXPECT_EQ(stellar_session_mq_subscribe(&st, env.intrinsc_egress_topic_id, test_basic_on_session_ingress, plugin_id), 0);// Intentional error
+
 	EXPECT_EQ(stellar_session_mq_subscribe(&st, env.intrinsc_egress_topic_id, test_basic_on_session_egress, plugin_id), 0);
 
 	env.basic_exdata_idx=stellar_exdata_new_index(&st, "SESSION_EXDATA", test_basic_session_exdata_free,&env);
@@ -1113,7 +1116,8 @@ TEST(plugin_manager, session_plugin_on_intrinsic_ingress_egress) {
 
 	plugin_manager_exit(plug_mgr);
 
-	EXPECT_TRUE(env.basic_on_session_ingress_called == env.basic_on_session_egress_called && env.basic_on_session_ingress_called == env.N_session*env.N_per_session_pkt_cnt);
+	EXPECT_EQ(env.basic_on_session_ingress_called, env.basic_on_session_egress_called);
+	EXPECT_EQ(env.basic_on_session_ingress_called, env.N_session*env.N_per_session_pkt_cnt);
 	EXPECT_TRUE(env.basic_ctx_new_called == env.basic_ctx_free_called && env.basic_ctx_new_called == env.N_session);
 	EXPECT_EQ(env.basic_exdata_free_called, env.N_session);