summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoryangwei <[email protected]>2024-07-31 00:00:44 +0800
committerluwenpeng <[email protected]>2024-08-12 15:45:50 +0800
commit49539eb2533017a0865d804d9592db2df3f659f0 (patch)
tree0bee66e06b36ed9f38b4a52aaa32806799ea46ab
parent0414710399c7ff64b3ea0128cc39dc4d37d6e0a7 (diff)
🎈 perf(pacekt and tcp_segment init): reduce memset
-rw-r--r--src/packet/packet_utils.cpp2
-rw-r--r--src/stellar/stellar_core.cpp2
-rw-r--r--src/tcp_reassembly/tcp_reassembly.cpp8
3 files changed, 3 insertions, 9 deletions
diff --git a/src/packet/packet_utils.cpp b/src/packet/packet_utils.cpp
index dd14c8e..9048242 100644
--- a/src/packet/packet_utils.cpp
+++ b/src/packet/packet_utils.cpp
@@ -490,7 +490,7 @@ uint16_t packet_get_payload_len(const struct packet *pkt)
struct packet *packet_new(uint16_t pkt_len)
{
- struct packet *pkt = (struct packet *)calloc(1, sizeof(struct packet) + pkt_len);
+ struct packet *pkt = (struct packet *)malloc( sizeof(struct packet) + pkt_len);
if (pkt == NULL)
{
return NULL;
diff --git a/src/stellar/stellar_core.cpp b/src/stellar/stellar_core.cpp
index 83ea43d..cf3639e 100644
--- a/src/stellar/stellar_core.cpp
+++ b/src/stellar/stellar_core.cpp
@@ -185,7 +185,7 @@ static void *work_thread(void *arg)
* Suggestion: After modifying the system time, restart the service to ensure consistent timing.
*/
now_ms = stellar_get_real_time_msec();
- memset(packets, 0, sizeof(packets));
+ //memset(packets, 0, sizeof(packets));
nr_recv = packet_io_ingress(packet_io, thr_idx, packets, RX_BURST_MAX);
if (nr_recv == 0)
{
diff --git a/src/tcp_reassembly/tcp_reassembly.cpp b/src/tcp_reassembly/tcp_reassembly.cpp
index 09de07c..61a5b14 100644
--- a/src/tcp_reassembly/tcp_reassembly.cpp
+++ b/src/tcp_reassembly/tcp_reassembly.cpp
@@ -32,13 +32,7 @@ struct tcp_reassembly
struct tcp_segment *tcp_segment_new(uint32_t seq, const void *data, uint32_t len)
{
- struct tcp_segment_private *p = (struct tcp_segment_private *)calloc(1, sizeof(struct tcp_segment_private) + len);
- if (!p)
- {
- TCP_REASSEMBLY_LOG_ERROR("calloc failed");
- return NULL;
- }
-
+ struct tcp_segment_private *p = (struct tcp_segment_private *)malloc(sizeof(struct tcp_segment_private) + len);
p->node.start = seq;
p->node.last = (uint64_t)seq + (uint64_t)len - 1;
p->data = (char *)p + sizeof(struct tcp_segment_private);