style: add some issues found during code review and some suggestions for fixes

6 files changed, 7 insertions, 5 deletions

diff --git a/config/grootstream_env.sh b/config/grootstream_env.sh
index 69fa8d3..1078232 100644
--- a/config/grootstream_env.sh
+++ b/config/grootstream_env.sh
@@ -1,4 +1,5 @@
 #!/usr/bin/env bash
+# TODO file sep
 # Home directory of flink distribution.
 FLINK_HOME=${FLINK_HOME:-/opt/flink}
 FLINK_JOB_MANAGER_ADDRESS=${FLINK_JOB_MANAGER_ADDRESS:-localhost:8081}
diff --git a/groot-common/src/main/java/com/geedgenetworks/common/config/GrootStreamDomConfigProcessor.java b/groot-common/src/main/java/com/geedgenetworks/common/config/GrootStreamDomConfigProcessor.java
index d0c3fae..c3f7a20 100644
--- a/groot-common/src/main/java/com/geedgenetworks/common/config/GrootStreamDomConfigProcessor.java
+++ b/groot-common/src/main/java/com/geedgenetworks/common/config/GrootStreamDomConfigProcessor.java
@@ -3,6 +3,7 @@ package com.geedgenetworks.common.config;
 import com.hazelcast.internal.config.AbstractDomConfigProcessor;
 import com.hazelcast.logging.ILogger;
 import com.hazelcast.logging.Logger;
+import lombok.extern.slf4j.Slf4j;
 import org.slf4j.LoggerFactory;
 import org.w3c.dom.Node;
 
@@ -13,6 +14,7 @@ import java.util.Map;
 
 import static com.hazelcast.internal.config.DomConfigHelper.*;
 
+@Slf4j
 public class GrootStreamDomConfigProcessor extends AbstractDomConfigProcessor {
     // TODO 日志规范：使用日志门面 slf4j 代替
     private static final ILogger LOGGER = Logger.getLogger(GrootStreamDomConfigProcessor.class);
diff --git a/groot-common/src/main/java/com/geedgenetworks/common/utils/DistributedLock.java b/groot-common/src/main/java/com/geedgenetworks/common/utils/DistributedLock.java
index 56ba733..23db8da 100644
--- a/groot-common/src/main/java/com/geedgenetworks/common/utils/DistributedLock.java
+++ b/groot-common/src/main/java/com/geedgenetworks/common/utils/DistributedLock.java
@@ -27,7 +27,7 @@ public class DistributedLock implements Lock, Watcher {
     /** 当前锁 */
     private String currentLock;
     /** 计数器 */
-    private CountDownLatch countDownLatch;
+    private volatile CountDownLatch countDownLatch;
 
     private int sessionTimeout = 2000;
 
diff --git a/groot-common/src/main/java/com/geedgenetworks/common/utils/HttpClientUtils.java b/groot-common/src/main/java/com/geedgenetworks/common/utils/HttpClientUtils.java
index fe75bb1..00c06e4 100644
--- a/groot-common/src/main/java/com/geedgenetworks/common/utils/HttpClientUtils.java
+++ b/groot-common/src/main/java/com/geedgenetworks/common/utils/HttpClientUtils.java
@@ -348,8 +348,8 @@ public class HttpClientUtils {
                 }
             }
             // TODO return 代码块应先于 finally 代码块一步被压入方法栈
-            return result;
         }
+        return result;
     }
 
 
diff --git a/groot-common/src/main/java/com/geedgenetworks/common/utils/ReflectionUtils.java b/groot-common/src/main/java/com/geedgenetworks/common/utils/ReflectionUtils.java
index 8430c07..188c5fe 100644
--- a/groot-common/src/main/java/com/geedgenetworks/common/utils/ReflectionUtils.java
+++ b/groot-common/src/main/java/com/geedgenetworks/common/utils/ReflectionUtils.java
@@ -10,7 +10,6 @@ public class ReflectionUtils {
     public static Optional<Method> getDeclaredMethod(
             Class<?> clazz, String methodName, Class<?>... parameterTypes) {
 
-        Optional<Method> method = Optional.empty();
         Method m;
         // TODO 使用 getMethod + getDeclaredMethod 代替 循环 + getSuperclass
         for (; clazz != null; clazz = clazz.getSuperclass()) {
@@ -23,7 +22,7 @@ public class ReflectionUtils {
             }
         }
 
-        return method;
+        return Optional.empty();
     }
 
     public static Optional<Object> getField(Object object, Class<?> clazz, String fieldName) {
diff --git a/groot-connectors/connector-ipfix-collector/src/main/java/com/geedgenetworks/connectors/ipfix/collector/UDPSource.java b/groot-connectors/connector-ipfix-collector/src/main/java/com/geedgenetworks/connectors/ipfix/collector/UDPSource.java
index 18da00a..21dd116 100644
--- a/groot-connectors/connector-ipfix-collector/src/main/java/com/geedgenetworks/connectors/ipfix/collector/UDPSource.java
+++ b/groot-connectors/connector-ipfix-collector/src/main/java/com/geedgenetworks/connectors/ipfix/collector/UDPSource.java
@@ -92,7 +92,7 @@ public class UDPSource extends RichParallelSourceFunction<byte[]> {
                     registerInstance(serverIp, currentPort);
                     break;
                 } catch (IOException e) {
-                    // FIXME 应该删减 try 代码块中的代码，而非 判断 message format
+                    // TODO 应该删减 try 代码块中的代码，而非 判断 message format
                     if (e.getMessage().contains("Address already in use")) {
                         logger.info("端口 " + currentPort + " 已被占用");
                         currentPort++;